Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-16 Thread Conor Dooley
> > No they can't. For a "regular extension" you populate the DT with the > > extension. For these extensions it has to put negated properties in the > > DT, otherwise it is incorrectly describing the hardware it is emulating. > > That is handling them differently in my book! If QEMU generates an >

Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-15 Thread Alistair Francis
On Fri, Feb 16, 2024 at 6:00 AM Conor Dooley wrote: > > On Thu, Feb 15, 2024 at 08:11:45PM +0100, Andrew Jones wrote: > > On Thu, Feb 15, 2024 at 04:34:32PM +, Conor Dooley wrote: > > > On Thu, Feb 15, 2024 at 03:26:18PM +0100, Andrew Jones wrote: > > > > On Thu, Feb 15, 2024 at 01:33:47PM +00

Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-15 Thread Conor Dooley
On Thu, Feb 15, 2024 at 08:11:45PM +0100, Andrew Jones wrote: > On Thu, Feb 15, 2024 at 04:34:32PM +, Conor Dooley wrote: > > On Thu, Feb 15, 2024 at 03:26:18PM +0100, Andrew Jones wrote: > > > On Thu, Feb 15, 2024 at 01:33:47PM +, Conor Dooley wrote: > > > > On Fri, Feb 02, 2024 at 12:21:5

Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-15 Thread Andrew Jones
On Thu, Feb 15, 2024 at 04:34:32PM +, Conor Dooley wrote: > On Thu, Feb 15, 2024 at 03:26:18PM +0100, Andrew Jones wrote: > > On Thu, Feb 15, 2024 at 01:33:47PM +, Conor Dooley wrote: > > > On Fri, Feb 02, 2024 at 12:21:51PM -0300, Daniel Henrique Barboza wrote: > > > > The RVA22U64 and RVA

Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-15 Thread Conor Dooley
On Thu, Feb 15, 2024 at 03:26:18PM +0100, Andrew Jones wrote: > On Thu, Feb 15, 2024 at 01:33:47PM +, Conor Dooley wrote: > > On Fri, Feb 02, 2024 at 12:21:51PM -0300, Daniel Henrique Barboza wrote: > > > The RVA22U64 and RVA22S64 profiles mandates certain extensions that, > > > until now, we w

Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-15 Thread Andrew Jones
On Thu, Feb 15, 2024 at 11:13:51AM -0300, Daniel Henrique Barboza wrote: ... > > I want to raise my frustration with the crock we've been given here by > > RVI. Any "named feature" that just creates a name for something that > > already is assumed is completely useless, and DT property that is used

Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-15 Thread Andrew Jones
On Thu, Feb 15, 2024 at 01:33:47PM +, Conor Dooley wrote: > On Fri, Feb 02, 2024 at 12:21:51PM -0300, Daniel Henrique Barboza wrote: > > The RVA22U64 and RVA22S64 profiles mandates certain extensions that, > > until now, we were implying that they were available. > > > > We can't do this anymo

Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-15 Thread Daniel Henrique Barboza
On 2/15/24 10:33, Conor Dooley wrote: On Fri, Feb 02, 2024 at 12:21:51PM -0300, Daniel Henrique Barboza wrote: The RVA22U64 and RVA22S64 profiles mandates certain extensions that, until now, we were implying that they were available. We can't do this anymore since named features also has a r

Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-15 Thread Conor Dooley
On Fri, Feb 02, 2024 at 12:21:51PM -0300, Daniel Henrique Barboza wrote: > The RVA22U64 and RVA22S64 profiles mandates certain extensions that, > until now, we were implying that they were available. > > We can't do this anymore since named features also has a riscv,isa > entry. Let's add them to

Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-14 Thread Alistair Francis
On Sat, Feb 3, 2024 at 1:24 AM Daniel Henrique Barboza wrote: > > The RVA22U64 and RVA22S64 profiles mandates certain extensions that, > until now, we were implying that they were available. > > We can't do this anymore since named features also has a riscv,isa > entry. Let's add them to riscv_cpu

Re: [PATCH v3 3/6] target/riscv: add remaining named features

2024-02-05 Thread Andrew Jones
On Fri, Feb 02, 2024 at 12:21:51PM -0300, Daniel Henrique Barboza wrote: > The RVA22U64 and RVA22S64 profiles mandates certain extensions that, > until now, we were implying that they were available. > > We can't do this anymore since named features also has a riscv,isa > entry. Let's add them to

[PATCH v3 3/6] target/riscv: add remaining named features

2024-02-02 Thread Daniel Henrique Barboza
The RVA22U64 and RVA22S64 profiles mandates certain extensions that, until now, we were implying that they were available. We can't do this anymore since named features also has a riscv,isa entry. Let's add them to riscv_cpu_named_features[]. Instead of adding one bool for each named feature that