Re: [PATCH v3 3/5] hw/net/lan9118_phy: Fix off-by-one error in MII_ANLPAR register

2024-12-02 Thread Peter Maydell
On Sat, 2 Nov 2024 at 12:57, Bernhard Beschow wrote: > > Turns 0x70 into 0xe0 (== 0x70 << 1) which adds the missing MII_ANLPAR_TX and > fixes the MSB of selector field to be zero, as specified in the datasheet. > > Fixes: 2a424990170b "LAN9118 emulation" > Signed-off-by: Bernhard Beschow > --- >

Re: [PATCH v3 3/5] hw/net/lan9118_phy: Fix off-by-one error in MII_ANLPAR register

2024-11-04 Thread Guenter Roeck
On Sat, Nov 02, 2024 at 01:57:22PM +0100, Bernhard Beschow wrote: > Turns 0x70 into 0xe0 (== 0x70 << 1) which adds the missing MII_ANLPAR_TX and > fixes the MSB of selector field to be zero, as specified in the datasheet. > > Fixes: 2a424990170b "LAN9118 emulation" > Signed-off-by: Bernhard Bescho

[PATCH v3 3/5] hw/net/lan9118_phy: Fix off-by-one error in MII_ANLPAR register

2024-11-02 Thread Bernhard Beschow
Turns 0x70 into 0xe0 (== 0x70 << 1) which adds the missing MII_ANLPAR_TX and fixes the MSB of selector field to be zero, as specified in the datasheet. Fixes: 2a424990170b "LAN9118 emulation" Signed-off-by: Bernhard Beschow --- hw/net/lan9118_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 delet