Re: [PATCH v3 3/4] nbd: Don't send oversize strings

2019-11-15 Thread Eric Blake
On 11/15/19 11:08 AM, Vladimir Sementsov-Ogievskiy wrote: 14.11.2019 5:46, Eric Blake wrote: Qemu as server currently won't accept export names larger than 256 bytes, nor create dirty bitmap names longer than 1023 bytes, so most uses of qemu as client or server have no reason to get anywhere nea

Re: [PATCH v3 3/4] nbd: Don't send oversize strings

2019-11-15 Thread Vladimir Sementsov-Ogievskiy
14.11.2019 5:46, Eric Blake wrote: > Qemu as server currently won't accept export names larger than 256 > bytes, nor create dirty bitmap names longer than 1023 bytes, so most > uses of qemu as client or server have no reason to get anywhere near > the NBD spec maximum of a 4k limit per string. > >

Re: [PATCH v3 3/4] nbd: Don't send oversize strings

2019-11-14 Thread Maxim Levitsky
On Wed, 2019-11-13 at 20:46 -0600, Eric Blake wrote: > Qemu as server currently won't accept export names larger than 256 > bytes, nor create dirty bitmap names longer than 1023 bytes, so most > uses of qemu as client or server have no reason to get anywhere near > the NBD spec maximum of a 4k limi

[PATCH v3 3/4] nbd: Don't send oversize strings

2019-11-13 Thread Eric Blake
Qemu as server currently won't accept export names larger than 256 bytes, nor create dirty bitmap names longer than 1023 bytes, so most uses of qemu as client or server have no reason to get anywhere near the NBD spec maximum of a 4k limit per string. However, we weren't actually enforcing things,