Re: [PATCH v3 3/4] accel/tcg: Remove #ifdef TARGET_I386 from perf.c

2023-12-11 Thread Richard Henderson
On 12/7/23 16:35, Ilya Leoshkevich wrote: Preparation for moving perf.c to tcg/. This affects only profiling guest code, which has code in a non-0 based segment, e.g., 16-bit code, which is not particularly important. Suggested-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- accel

Re: [PATCH v3 3/4] accel/tcg: Remove #ifdef TARGET_I386 from perf.c

2023-12-08 Thread Ilya Leoshkevich
On Fri, 2023-12-08 at 09:53 +, Alex Bennée wrote: > Ilya Leoshkevich writes: > > > Preparation for moving perf.c to tcg/. > > > > This affects only profiling guest code, which has code in a non-0 > > based > > segment, e.g., 16-bit code, which is not particularly important. > > I have no ob

Re: [PATCH v3 3/4] accel/tcg: Remove #ifdef TARGET_I386 from perf.c

2023-12-08 Thread Alex Bennée
Ilya Leoshkevich writes: > Preparation for moving perf.c to tcg/. > > This affects only profiling guest code, which has code in a non-0 based > segment, e.g., 16-bit code, which is not particularly important. I have no objection to removing the wart. Is it worth adding a note:: to tcg.rst to say

[PATCH v3 3/4] accel/tcg: Remove #ifdef TARGET_I386 from perf.c

2023-12-07 Thread Ilya Leoshkevich
Preparation for moving perf.c to tcg/. This affects only profiling guest code, which has code in a non-0 based segment, e.g., 16-bit code, which is not particularly important. Suggested-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- accel/tcg/perf.c | 4 1 file changed, 4 delet