Re: [PATCH v3 27/30] target/ppc: Move D/DS/X-form integer loads to decodetree

2021-05-03 Thread Matheus K. Ferst
On 30/04/2021 21:50, Richard Henderson wrote: On 4/30/21 4:54 PM, Matheus K. Ferst wrote: The only difference between those two is tcg_gen_addi_tl/tcg_gen_movi_tl and tcg_gen_add_tl/tcg_gen_mov_tl. We could do this in a single method if we tcg_const_tl(a->si) in do_ldst_D. I'm not sure about t

Re: [PATCH v3 27/30] target/ppc: Move D/DS/X-form integer loads to decodetree

2021-04-30 Thread Richard Henderson
On 4/30/21 4:54 PM, Matheus K. Ferst wrote: The only difference between those two is tcg_gen_addi_tl/tcg_gen_movi_tl and tcg_gen_add_tl/tcg_gen_mov_tl. We could do this in a single method if we tcg_const_tl(a->si) in do_ldst_D. I'm not sure about the costs involved, and we'd need to tcg_temp_fr

Re: [PATCH v3 27/30] target/ppc: Move D/DS/X-form integer loads to decodetree

2021-04-30 Thread Matheus K. Ferst
On 29/04/2021 22:15, Richard Henderson wrote: These are all connected by macros in the legacy decoding. Decode the D and DS forms into the PLS_D argument set so that prefixed insns can share code. Signed-off-by: Richard Henderson --- target/ppc/insn32.decode | 37 ++ t

[PATCH v3 27/30] target/ppc: Move D/DS/X-form integer loads to decodetree

2021-04-29 Thread Richard Henderson
These are all connected by macros in the legacy decoding. Decode the D and DS forms into the PLS_D argument set so that prefixed insns can share code. Signed-off-by: Richard Henderson --- target/ppc/insn32.decode | 37 ++ target/ppc/translate.c | 145 ++