Re: [PATCH v3 25/43] target/loongarch: Add LoongArch CSR instruction

2022-05-05 Thread yangxiaojuan
Hi Richard, On 2022/5/1 上午1:22, Richard Henderson wrote: On 4/29/22 03:07, Xiaojuan Yang wrote: +    [LOONGARCH_CSR_CPUID] = { +    .offset = -1, +    .flags = CSRFL_READONLY, +    .readfn = gen_helper_csrrd_cpuid, +    .writefn = NULL +    }, The offset should be     (int)of

Re: [PATCH v3 25/43] target/loongarch: Add LoongArch CSR instruction

2022-04-30 Thread Richard Henderson
On 4/29/22 03:07, Xiaojuan Yang wrote: +[LOONGARCH_CSR_CPUID] = { +.offset = -1, +.flags = CSRFL_READONLY, +.readfn = gen_helper_csrrd_cpuid, +.writefn = NULL +}, The offset should be (int)offsetof(CPUState, cpu_index) - (int)offsetof(LoongArchCPU, e

[PATCH v3 25/43] target/loongarch: Add LoongArch CSR instruction

2022-04-29 Thread Xiaojuan Yang
This includes: - CSRRD - CSRWR - CSRXCHG Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao --- target/loongarch/csr_helper.c | 92 ++ target/loongarch/disas.c | 101 +++ target/loongarch/helper.h | 9 + .../insn_trans/trans_