Re: [PATCH v3 23/23] migration: Use multifd before we check for the zero page

2021-12-14 Thread Peter Xu
On Mon, Dec 13, 2021 at 10:03:53AM +0100, Juan Quintela wrote: > Peter Xu wrote: > > On Thu, Dec 02, 2021 at 06:38:27PM +0100, Juan Quintela wrote: > >> This needs to be improved to be compatible with old versions. > > > > Any plan to let new binary work with old binary? > > Yes, but I was waitin

Re: [PATCH v3 23/23] migration: Use multifd before we check for the zero page

2021-12-13 Thread Juan Quintela
Peter Xu wrote: > On Thu, Dec 02, 2021 at 06:38:27PM +0100, Juan Quintela wrote: >> This needs to be improved to be compatible with old versions. > > Any plan to let new binary work with old binary? Yes, but I was waiting for 7.0 to get out. Basically I need to do: if (old) run the old code

Re: [PATCH v3 23/23] migration: Use multifd before we check for the zero page

2021-12-06 Thread Peter Xu
On Thu, Dec 02, 2021 at 06:38:27PM +0100, Juan Quintela wrote: > This needs to be improved to be compatible with old versions. Any plan to let new binary work with old binary? Maybe boost the version field for multifd packet (along with a multifd_version=2 parameter and only set on new machine ty

Re: [PATCH v3 23/23] migration: Use multifd before we check for the zero page

2021-12-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> So we use multifd to transmit zero pages. > >> > >> Signed-off-by: Juan Quintela > >> --- > >> migration/ram.c | 22 +++--- > >> 1 file changed, 1

Re: [PATCH v3 23/23] migration: Use multifd before we check for the zero page

2021-12-02 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> So we use multifd to transmit zero pages. >> >> Signed-off-by: Juan Quintela >> --- >> migration/ram.c | 22 +++--- >> 1 file changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/migratio

Re: [PATCH v3 23/23] migration: Use multifd before we check for the zero page

2021-12-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > So we use multifd to transmit zero pages. > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 57efa67f2

[PATCH v3 23/23] migration: Use multifd before we check for the zero page

2021-11-24 Thread Juan Quintela
So we use multifd to transmit zero pages. Signed-off-by: Juan Quintela --- migration/ram.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 57efa67f20..3ae094f653 100644 --- a/migration/ram.c +++ b/migration/ram.