Re: [PATCH v3 20/20] aio: remove aio_disable_external() API

2023-04-25 Thread Stefan Hajnoczi
On Thu, Apr 20, 2023 at 03:44:06PM +0200, Philippe Mathieu-Daudé wrote: > On 20/4/23 13:37, Stefan Hajnoczi wrote: > > All callers now pass is_external=false to aio_set_fd_handler() and > > aio_set_event_notifier(). The aio_disable_external() API that > > temporarily disables fd handlers that were

Re: [PATCH v3 20/20] aio: remove aio_disable_external() API

2023-04-20 Thread Philippe Mathieu-Daudé
On 20/4/23 13:37, Stefan Hajnoczi wrote: All callers now pass is_external=false to aio_set_fd_handler() and aio_set_event_notifier(). The aio_disable_external() API that temporarily disables fd handlers that were registered is_external=true is therefore dead code. Remove aio_disable_external(),

[PATCH v3 20/20] aio: remove aio_disable_external() API

2023-04-20 Thread Stefan Hajnoczi
All callers now pass is_external=false to aio_set_fd_handler() and aio_set_event_notifier(). The aio_disable_external() API that temporarily disables fd handlers that were registered is_external=true is therefore dead code. Remove aio_disable_external(), aio_enable_external(), and the is_external