Re: [PATCH v3 2/9] hw/pci-host/q35: Inline sysbus_add_io()

2023-02-05 Thread Bernhard Beschow
Am 5. Februar 2023 11:12:26 UTC schrieb "Philippe Mathieu-Daudé" : >On 4/2/23 16:10, Bernhard Beschow wrote: >> sysbus_add_io() just wraps memory_region_add_subregion() while also >> obscuring where the memory is attached. So use >> memory_region_add_subregion() directly and attach it to the ex

Re: [PATCH v3 2/9] hw/pci-host/q35: Inline sysbus_add_io()

2023-02-05 Thread Philippe Mathieu-Daudé
On 4/2/23 16:10, Bernhard Beschow wrote: sysbus_add_io() just wraps memory_region_add_subregion() while also obscuring where the memory is attached. So use memory_region_add_subregion() directly and attach it to the existing memory region s->mch.address_space_io which is set as an alias to get_sy

[PATCH v3 2/9] hw/pci-host/q35: Inline sysbus_add_io()

2023-02-04 Thread Bernhard Beschow
sysbus_add_io() just wraps memory_region_add_subregion() while also obscuring where the memory is attached. So use memory_region_add_subregion() directly and attach it to the existing memory region s->mch.address_space_io which is set as an alias to get_system_io() by the q35 machine. Signed-off-b