> > To be more specific, it is either a x264 encoder bug, or a web
> > browser (VideoEncoder api) bug. You can reproduce it with noVNC.
> >
> > Form what I found out, newer versions of x264 do not use the problematic
> > mode at all (but we want to support older versions).
>
> Do you have exampl
On Fri, Apr 18, 2025 at 01:29:46PM +0200, Dietmar Maurer wrote:
> This patch implements H264 support for VNC. The RFB protocol
> extension is defined in:
>
> https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#open-h-264-encoding
>
> Currently the Gstreamer x264enc plugin (software enco
On Thu, Apr 24, 2025 at 12:39:22PM +0200, Dietmar Maurer wrote:
> > > +g_object_set(
> > > +vs->h264->gst_encoder,
> > > +"tune", 4, /* zerolatency */
> > > +/*
> > > + * fix for zerolatency with novnc (without, noVNC displays
> > > + * green stripes)
> >
> > +g_object_set(
> > +vs->h264->gst_encoder,
> > +"tune", 4, /* zerolatency */
> > +/*
> > + * fix for zerolatency with novnc (without, noVNC displays
> > + * green stripes)
> > + */
> > +"threads", 1,
>
> It seems a bit dubious for QEM
On Thu, Apr 24, 2025 at 11:28:34AM +0200, Dietmar Maurer wrote:
> > > > > +void vnc_h264_clear(VncState *vs)
> > > > > +{
> > > > > +if (!vs->h264) {
> > > > > +return;
> > > > > +}
> > > >
> > > > unnecessary
> > >
> > > This is required. For example if you disable h264, vs->h264 i
> > > > +void vnc_h264_clear(VncState *vs)
> > > > +{
> > > > +if (!vs->h264) {
> > > > +return;
> > > > +}
> > >
> > > unnecessary
> >
> > This is required. For example if you disable h264, vs->h264 is
> > always NULL, and we unconditionally call vnc_h264_clear().
> >
> > Why do yo
On Thu, Apr 24, 2025 at 10:43:21AM +0200, Dietmar Maurer wrote:
>
> > On 24.4.2025 09:32 CEST Dietmar Maurer wrote:
> >
> >
> > > > +gst_object_ref(vs->h264->source);
> > > > +if (!gst_bin_add(GST_BIN(vs->h264->pipeline), vs->h264->source)) {
> > > > +gst_object_unref(vs->h264-
> On 24.4.2025 09:32 CEST Dietmar Maurer wrote:
>
>
> > > +gst_object_ref(vs->h264->source);
> > > +if (!gst_bin_add(GST_BIN(vs->h264->pipeline), vs->h264->source)) {
> > > +gst_object_unref(vs->h264->source);
> > > +VNC_DEBUG("Could not add source to gst pipeline\n");
On Thu, Apr 24, 2025 at 08:19:25AM +0200, Dietmar Maurer wrote:
> > > > > +VNC_DEBUG("Could not add source to gst pipeline\n");
> > > > > +goto error;
> > > > > +}
> > > > > +
> > > > > +gst_object_ref(vs->h264->convert);
> > > > > +if (!gst_bin_add(GST_BIN(vs->h264->pip
> > +gst_object_ref(vs->h264->source);
> > +if (!gst_bin_add(GST_BIN(vs->h264->pipeline), vs->h264->source)) {
> > +gst_object_unref(vs->h264->source);
> > +VNC_DEBUG("Could not add source to gst pipeline\n");
> > +goto error;
> > +}
>
> If you put the gst_obj
> > > > +VNC_DEBUG("Could not add source to gst pipeline\n");
> > > > +goto error;
> > > > +}
> > > > +
> > > > +gst_object_ref(vs->h264->convert);
> > > > +if (!gst_bin_add(GST_BIN(vs->h264->pipeline), vs->h264->convert)) {
> > >
> > > Can you use gst_bin_add_many() ?
>
On Fri, Apr 18, 2025 at 01:29:46PM +0200, Dietmar Maurer wrote:
> This patch implements H264 support for VNC. The RFB protocol
> extension is defined in:
>
> https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#open-h-264-encoding
>
> Currently the Gstreamer x264enc plugin (software enco
Hi
On Wed, Apr 23, 2025 at 3:46 PM Dietmar Maurer wrote:
>
> > On 19.4.2025 07:24 CEST Marc-André Lureau
> > wrote:
> >
> >
> > Hi
> >
> > On Fri, Apr 18, 2025 at 3:41 PM Dietmar Maurer wrote:
> > >
> > > This patch implements H264 support for VNC. The RFB protocol
> > > extension is defined i
On Fri, Apr 18, 2025 at 01:29:46PM +0200, Dietmar Maurer wrote:
> This patch implements H264 support for VNC. The RFB protocol
> extension is defined in:
>
> https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#open-h-264-encoding
>
> Currently the Gstreamer x264enc plugin (software enco
> On 19.4.2025 07:24 CEST Marc-André Lureau wrote:
>
>
> Hi
>
> On Fri, Apr 18, 2025 at 3:41 PM Dietmar Maurer wrote:
> >
> > This patch implements H264 support for VNC. The RFB protocol
> > extension is defined in:
> >
> > https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#open-h-
Hi
On Fri, Apr 18, 2025 at 3:41 PM Dietmar Maurer wrote:
>
> This patch implements H264 support for VNC. The RFB protocol
> extension is defined in:
>
> https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#open-h-264-encoding
>
> Currently the Gstreamer x264enc plugin (software encoder)
This patch implements H264 support for VNC. The RFB protocol
extension is defined in:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#open-h-264-encoding
Currently the Gstreamer x264enc plugin (software encoder) is used
to encode the video stream.
The gstreamer pipe is:
appsrc ->
17 matches
Mail list logo
