Re: [PATCH v3 2/7] migration: Implement switchover ack logic

2023-05-28 Thread Avihai Horon
On 25/05/2023 15:44, Peter Xu wrote: External email: Use caution opening links or attachments On Thu, May 25, 2023 at 12:51:46PM +0300, Avihai Horon wrote: However, there is one issue -- we can't send the ACK up here [1], as at that point the return path has not been created yet. A possible

Re: [PATCH v3 2/7] migration: Implement switchover ack logic

2023-05-25 Thread Peter Xu
On Thu, May 25, 2023 at 12:51:46PM +0300, Avihai Horon wrote: > However, there is one issue -- we can't send the ACK up here [1], as at that > point the return path has not been created yet. > A possible solution is to check for mis->switchover_ack_pending_num == 0 > when we create the return path

Re: [PATCH v3 2/7] migration: Implement switchover ack logic

2023-05-25 Thread Avihai Horon
On 24/05/2023 22:32, Peter Xu wrote: External email: Use caution opening links or attachments On Sun, May 21, 2023 at 06:18:03PM +0300, Avihai Horon wrote: Implement switchover ack logic. This prevents the source from stopping the VM and completing the migration until an ACK is received from

Re: [PATCH v3 2/7] migration: Implement switchover ack logic

2023-05-24 Thread Peter Xu
On Sun, May 21, 2023 at 06:18:03PM +0300, Avihai Horon wrote: > Implement switchover ack logic. This prevents the source from stopping > the VM and completing the migration until an ACK is received from the > destination that it's OK to do so. > > To achieve this, a new SaveVMHandlers handler swit

[PATCH v3 2/7] migration: Implement switchover ack logic

2023-05-21 Thread Avihai Horon
Implement switchover ack logic. This prevents the source from stopping the VM and completing the migration until an ACK is received from the destination that it's OK to do so. To achieve this, a new SaveVMHandlers handler switchover_ack_needed() and a new return path message MIG_RP_MSG_SWITCHOVER_