Re: [PATCH v3 2/4] util: introduce qemu_open and qemu_create with error reporting

2020-07-27 Thread Markus Armbruster
Daniel P. Berrangé writes: > This introduces two new helper metohds Typo metohds. Suggest to be a bit more explicit on why we want to replace qemu_open(), perhaps like this: qemu_open_old() works like open(): set errno and return -1 on failure. It has even more failure modes, though. Repo

Re: [PATCH v3 2/4] util: introduce qemu_open and qemu_create with error reporting

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 3:25 PM, Daniel P. Berrangé wrote: > This introduces two new helper metohds > > int qemu_open(const char *name, int flags, Error **errp); > int qemu_create(const char *name, int flags, mode_t mode, Error **errp); > > Note that with this design we no longer require or even accept th

Re: [PATCH v3 2/4] util: introduce qemu_open and qemu_create with error reporting

2020-07-24 Thread Eric Blake
On 7/24/20 8:25 AM, Daniel P. Berrangé wrote: This introduces two new helper metohds int qemu_open(const char *name, int flags, Error **errp); int qemu_create(const char *name, int flags, mode_t mode, Error **errp); Note that with this design we no longer require or even accept the O_CREA

[PATCH v3 2/4] util: introduce qemu_open and qemu_create with error reporting

2020-07-24 Thread Daniel P . Berrangé
This introduces two new helper metohds int qemu_open(const char *name, int flags, Error **errp); int qemu_create(const char *name, int flags, mode_t mode, Error **errp); Note that with this design we no longer require or even accept the O_CREAT flag. Avoiding overloading the two distinct oper