Re: [PATCH v3 2/4] qtest/libqos/pci: Enforce balanced iomap/unmap

2025-01-20 Thread Philippe Mathieu-Daudé
On 21/1/25 05:39, Nicholas Piggin wrote: On Mon Jan 20, 2025 at 3:29 PM AEST, Philippe Mathieu-Daudé wrote: Hi Nick, Only nitpicking comments... Hey, no they're good comments actually. On 17/1/25 18:22, Nicholas Piggin wrote: Add assertions to ensure a BAR is not mapped twice, and only pr

Re: [PATCH v3 2/4] qtest/libqos/pci: Enforce balanced iomap/unmap

2025-01-20 Thread Nicholas Piggin
On Mon Jan 20, 2025 at 3:29 PM AEST, Philippe Mathieu-Daudé wrote: > Hi Nick, > > Only nitpicking comments... Hey, no they're good comments actually. > > On 17/1/25 18:22, Nicholas Piggin wrote: >> Add assertions to ensure a BAR is not mapped twice, and only >> previously mapped BARs are unmapped

Re: [PATCH v3 2/4] qtest/libqos/pci: Enforce balanced iomap/unmap

2025-01-19 Thread Philippe Mathieu-Daudé
Hi Nick, Only nitpicking comments... On 17/1/25 18:22, Nicholas Piggin wrote: Add assertions to ensure a BAR is not mapped twice, and only previously mapped BARs are unmapped. This can help catch some bugs. Reviewed-by: Fabiano Rosas Signed-off-by: Nicholas Piggin --- tests/qtest/libqos/ah

[PATCH v3 2/4] qtest/libqos/pci: Enforce balanced iomap/unmap

2025-01-17 Thread Nicholas Piggin
Add assertions to ensure a BAR is not mapped twice, and only previously mapped BARs are unmapped. This can help catch some bugs. Reviewed-by: Fabiano Rosas Signed-off-by: Nicholas Piggin --- tests/qtest/libqos/ahci.h | 1 + tests/qtest/libqos/pci.h| 2 ++ tests/qtest/libqos/virt