Re: [PATCH v3 2/2] sev: update sev-inject-launch-secret to make gpa optional

2021-02-08 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 05/02/21 12:37, Daniel P. Berrangé wrote: > > On Fri, Feb 05, 2021 at 11:58:26AM +0100, Paolo Bonzini wrote: > > > On 05/02/21 10:51, Daniel P. Berrangé wrote: > > > > > +if (!pc_system_ovmf_table_find(SEV_SECRET_GUID, &data, > > > > > NULL

Re: [PATCH v3 2/2] sev: update sev-inject-launch-secret to make gpa optional

2021-02-05 Thread Daniel P . Berrangé
On Fri, Feb 05, 2021 at 12:45:18PM +0100, Paolo Bonzini wrote: > On 05/02/21 12:37, Daniel P. Berrangé wrote: > > On Fri, Feb 05, 2021 at 11:58:26AM +0100, Paolo Bonzini wrote: > > > On 05/02/21 10:51, Daniel P. Berrangé wrote: > > > > > +if (!pc_system_ovmf_table_find(SEV_SECRET_GUID, &dat

Re: [PATCH v3 2/2] sev: update sev-inject-launch-secret to make gpa optional

2021-02-05 Thread Paolo Bonzini
On 05/02/21 12:37, Daniel P. Berrangé wrote: On Fri, Feb 05, 2021 at 11:58:26AM +0100, Paolo Bonzini wrote: On 05/02/21 10:51, Daniel P. Berrangé wrote: +if (!pc_system_ovmf_table_find(SEV_SECRET_GUID, &data, NULL)) { +error_setg(errp, "SEV: no secret area found in OVMF," +

Re: [PATCH v3 2/2] sev: update sev-inject-launch-secret to make gpa optional

2021-02-05 Thread Daniel P . Berrangé
On Fri, Feb 05, 2021 at 11:58:26AM +0100, Paolo Bonzini wrote: > On 05/02/21 10:51, Daniel P. Berrangé wrote: > > > +if (!pc_system_ovmf_table_find(SEV_SECRET_GUID, &data, NULL)) { > > > +error_setg(errp, "SEV: no secret area found in OVMF," > > > + " gpa m

Re: [PATCH v3 2/2] sev: update sev-inject-launch-secret to make gpa optional

2021-02-05 Thread Paolo Bonzini
On 05/02/21 10:51, Daniel P. Berrangé wrote: +if (!pc_system_ovmf_table_find(SEV_SECRET_GUID, &data, NULL)) { +error_setg(errp, "SEV: no secret area found in OVMF," + " gpa must be specified."); +return; +} IIUC, historically QEMU has

Re: [PATCH v3 2/2] sev: update sev-inject-launch-secret to make gpa optional

2021-02-05 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 11:39:39AM -0800, James Bottomley wrote: > If the gpa isn't specified, it's value is extracted from the OVMF > properties table located below the reset vector (and if this doesn't > exist, an error is returned). OVMF has defined the GUID for the SEV > secret area as 4c2eb36

Re: [PATCH v3 2/2] sev: update sev-inject-launch-secret to make gpa optional

2021-02-04 Thread Dr. David Alan Gilbert
* James Bottomley (j...@linux.ibm.com) wrote: > If the gpa isn't specified, it's value is extracted from the OVMF > properties table located below the reset vector (and if this doesn't > exist, an error is returned). OVMF has defined the GUID for the SEV > secret area as 4c2eb361-7d9b-4cc3-8081-12

[PATCH v3 2/2] sev: update sev-inject-launch-secret to make gpa optional

2021-02-04 Thread James Bottomley
If the gpa isn't specified, it's value is extracted from the OVMF properties table located below the reset vector (and if this doesn't exist, an error is returned). OVMF has defined the GUID for the SEV secret area as 4c2eb361-7d9b-4cc3-8081-127c90d3d294 and the format of the is: | where both are