Re: [PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-13 Thread Max Reitz
On 13.11.20 17:26, Alberto Garcia wrote: On Fri 13 Nov 2020 05:11:20 PM CET, Max Reitz wrote: We could set all supported_zero_flags as long as all children support them, right? Sure, I was just thinking that we could set these regardless of whether the children support them, because (on zero-

Re: [PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-13 Thread Alberto Garcia
On Fri 13 Nov 2020 05:11:20 PM CET, Max Reitz wrote: >> We could set all supported_zero_flags as long as all children support >> them, right? > > Sure, I was just thinking that we could set these regardless of > whether the children support them, because (on zero-writes) the block > layer will fig

Re: [PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-13 Thread Max Reitz
On 13.11.20 17:07, Alberto Garcia wrote: On Fri 13 Nov 2020 12:49:04 PM CET, Max Reitz wrote: On 11.11.20 17:53, Alberto Garcia wrote: This simply calls bdrv_co_pwrite_zeroes() in all children Signed-off-by: Alberto Garcia --- block/quorum.c | 18 -- tests/qem

Re: [PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-13 Thread Alberto Garcia
On Fri 13 Nov 2020 12:49:04 PM CET, Max Reitz wrote: > On 11.11.20 17:53, Alberto Garcia wrote: >> This simply calls bdrv_co_pwrite_zeroes() in all children >> >> Signed-off-by: Alberto Garcia >> --- >> block/quorum.c | 18 -- >> tests/qemu-iotests/312 | 7

Re: [PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-13 Thread Max Reitz
On 11.11.20 17:53, Alberto Garcia wrote: This simply calls bdrv_co_pwrite_zeroes() in all children Signed-off-by: Alberto Garcia --- block/quorum.c | 18 -- tests/qemu-iotests/312 | 7 +++ tests/qemu-iotests/312.out | 4 3 files changed, 27 insert

[PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-11 Thread Alberto Garcia
This simply calls bdrv_co_pwrite_zeroes() in all children Signed-off-by: Alberto Garcia --- block/quorum.c | 18 -- tests/qemu-iotests/312 | 7 +++ tests/qemu-iotests/312.out | 4 3 files changed, 27 insertions(+), 2 deletions(-) diff --git a/block/quo