Re: [PATCH v3 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-06-25 Thread Klaus Jensen
On Jun 25 15:57, Andrzej Jakowski wrote: > On 6/25/20 4:13 AM, Klaus Jensen wrote: > > > > Come to think of it, the above might not even be sufficient since if just > > one > > of the nvme_addr_is_cmb checks fails, we end up issuing an invalid > > pci_dma_read. But I think that it will error out

Re: [PATCH v3 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-06-25 Thread Andrzej Jakowski
On 6/25/20 4:13 AM, Klaus Jensen wrote: > On Jun 22 11:25, Andrzej Jakowski wrote: >> So far it was not possible to have CMB and PMR emulated on the same >> device, because BAR2 was used exclusively either of PMR or CMB. This >> patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors

Re: [PATCH v3 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-06-25 Thread Klaus Jensen
On Jun 22 11:25, Andrzej Jakowski wrote: > So far it was not possible to have CMB and PMR emulated on the same > device, because BAR2 was used exclusively either of PMR or CMB. This > patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors. > > Signed-off-by: Andrzej Jakowski > ---

[PATCH v3 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-06-22 Thread Andrzej Jakowski
So far it was not possible to have CMB and PMR emulated on the same device, because BAR2 was used exclusively either of PMR or CMB. This patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors. Signed-off-by: Andrzej Jakowski --- hw/block/nvme.c | 119