Re: [PATCH v3 2/2] net/af-xdp: Fix up cleanup path upon failure in queue creation

2025-06-18 Thread Ilya Maximets
On 6/17/25 11:41 PM, Ilya Maximets wrote: > On 6/17/25 3:03 PM, Daniel Borkmann wrote: >> On 6/17/25 1:59 PM, Ilya Maximets wrote: >>> On 6/4/25 1:29 PM, Daniel Borkmann wrote: While testing, it turned out that upon error in the queue creation loop, we never trigger the af_xdp_cleanup() h

Re: [PATCH v3 2/2] net/af-xdp: Fix up cleanup path upon failure in queue creation

2025-06-17 Thread Ilya Maximets
On 6/17/25 3:03 PM, Daniel Borkmann wrote: > On 6/17/25 1:59 PM, Ilya Maximets wrote: >> On 6/4/25 1:29 PM, Daniel Borkmann wrote: >>> While testing, it turned out that upon error in the queue creation loop, >>> we never trigger the af_xdp_cleanup() handler. This is because we pass >>> errp instead

Re: [PATCH v3 2/2] net/af-xdp: Fix up cleanup path upon failure in queue creation

2025-06-17 Thread Ilya Maximets
On 6/4/25 1:29 PM, Daniel Borkmann wrote: > While testing, it turned out that upon error in the queue creation loop, > we never trigger the af_xdp_cleanup() handler. This is because we pass > errp instead of a local err pointer into the various AF_XDP setup functions > instead of a scheme like: >

Re: [PATCH v3 2/2] net/af-xdp: Fix up cleanup path upon failure in queue creation

2025-06-17 Thread Daniel Borkmann via
On 6/17/25 1:59 PM, Ilya Maximets wrote: On 6/4/25 1:29 PM, Daniel Borkmann wrote: While testing, it turned out that upon error in the queue creation loop, we never trigger the af_xdp_cleanup() handler. This is because we pass errp instead of a local err pointer into the various AF_XDP setup fun

[PATCH v3 2/2] net/af-xdp: Fix up cleanup path upon failure in queue creation

2025-06-04 Thread Daniel Borkmann via
While testing, it turned out that upon error in the queue creation loop, we never trigger the af_xdp_cleanup() handler. This is because we pass errp instead of a local err pointer into the various AF_XDP setup functions instead of a scheme like: bool fn(..., Error **errp) { Error *