Re: [PATCH v3 18/33] mips: inline serial_init

2019-11-20 Thread Marc-André Lureau
Hi On Mon, Nov 18, 2019 at 7:25 PM Peter Maydell wrote: > > On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau > wrote: > > > > The function is specific to mipssim, let's inline it. > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/char/serial.c | 16 > > hw/mips/mi

Re: [PATCH v3 18/33] mips: inline serial_init

2019-11-19 Thread Aleksandar Markovic
On Wednesday, October 23, 2019, Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > The function is specific to mipssim, let's inline it. > > Signed-off-by: Marc-André Lureau > --- > hw/char/serial.c | 16 > hw/mips/mips_mipssim.c | 13 ++--- > include/hw

Re: [PATCH v3 18/33] mips: inline serial_init

2019-11-18 Thread Peter Maydell
On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau wrote: > > The function is specific to mipssim, let's inline it. > > Signed-off-by: Marc-André Lureau > --- > hw/char/serial.c | 16 > hw/mips/mips_mipssim.c | 13 ++--- > include/hw/char/serial.h | 2 -- > 3 fil

[PATCH v3 18/33] mips: inline serial_init

2019-10-23 Thread Marc-André Lureau
The function is specific to mipssim, let's inline it. Signed-off-by: Marc-André Lureau --- hw/char/serial.c | 16 hw/mips/mips_mipssim.c | 13 ++--- include/hw/char/serial.h | 2 -- 3 files changed, 10 insertions(+), 21 deletions(-) diff --git a/hw/char/seria