Re: [PATCH v3 16/16] block_job_query: remove atomic read

2022-01-19 Thread Paolo Bonzini
On 1/5/22 15:02, Emanuele Giuseppe Esposito wrote: +++ b/blockjob.c @@ -335,13 +335,13 @@ BlockJobInfo *block_job_query(BlockJob *job, Error **errp) info = g_new0(BlockJobInfo, 1); info->type = g_strdup(job_type_str(&job->job)); info->device= g_strdup(job->job.id); -

[PATCH v3 16/16] block_job_query: remove atomic read

2022-01-05 Thread Emanuele Giuseppe Esposito
Not sure what the atomic here was supposed to do, since job.busy is protected by the job lock. Since the whole function is called under job_mutex, just remove the atomic. Signed-off-by: Emanuele Giuseppe Esposito --- blockjob.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi