Re: [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE

2022-03-30 Thread Victor Toso
Hi, On Tue, Mar 29, 2022 at 05:52:47PM +0200, Markus Armbruster wrote: > Victor Toso writes: > > > Example output lacks mandatory member @timestamp. Provide it. > > > > While @flags is an optional member, > > Uh, it isn't. Wow! I was so sure I saw "*flags" before. Nice catch. > >

Re: [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE

2022-03-29 Thread Markus Armbruster
Victor Toso writes: > Example output lacks mandatory member @timestamp. Provide it. > > While @flags is an optional member, Uh, it isn't. > if it is defined then all its > members should be include. For that reason, we add @recursive member. Perhaps: Exa

[PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE

2022-03-28 Thread Victor Toso
Example output lacks mandatory member @timestamp. Provide it. While @flags is an optional member, if it is defined then all its members should be include. For that reason, we add @recursive member. Minor: Change quotes from '' to "" in @action-required member. Signed-off-by: Victor Toso Review