Re: [PATCH v3 10/17] qapi/gen: Combine ._add_[user|system]_module

2021-01-20 Thread Markus Armbruster
John Snow writes: > On 1/20/21 9:20 AM, Markus Armbruster wrote: >> John Snow writes: [...] >>> diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py >>> index 55acd7e080d..b5505685e6e 100644 >>> --- a/scripts/qapi/gen.py >>> +++ b/scripts/qapi/gen.py [...] >>> @@ -313,7 +306,8 @@ def visit_mod

Re: [PATCH v3 10/17] qapi/gen: Combine ._add_[user|system]_module

2021-01-20 Thread John Snow
On 1/20/21 9:20 AM, Markus Armbruster wrote: John Snow writes: From: Markus Armbruster QAPISchemaModularCVisitor attempts to encapsulate the way it splits the module name space between user modules (name can't start with './') and system modules (name is None or starts with './') by Is thi

Re: [PATCH v3 10/17] qapi/gen: Combine ._add_[user|system]_module

2021-01-20 Thread Markus Armbruster
John Snow writes: > From: Markus Armbruster > > QAPISchemaModularCVisitor attempts to encapsulate the way it splits > the module name space between user modules (name can't start with > './') and system modules (name is None or starts with './') by Is this still accurate? > providing separate

[PATCH v3 10/17] qapi/gen: Combine ._add_[user|system]_module

2021-01-19 Thread John Snow
From: Markus Armbruster QAPISchemaModularCVisitor attempts to encapsulate the way it splits the module name space between user modules (name can't start with './') and system modules (name is None or starts with './') by providing separate ._add_user_module() and ._add_system_module(), where the