Re: [PATCH v3 1/8] dma/pl330: Convert to support tracing

2020-01-23 Thread Guenter Roeck
On Thu, Jan 23, 2020 at 04:23:59PM +, Peter Maydell wrote: > On Thu, 23 Jan 2020 at 15:51, Peter Maydell wrote: > > > > On Thu, 23 Jan 2020 at 05:25, Guenter Roeck wrote: > > > > > > Replace debug logging code with tracing. > > > > > > Reviewed-by: Peter Maydell > > > Signed-off-by: Guenter

Re: [PATCH v3 1/8] dma/pl330: Convert to support tracing

2020-01-23 Thread Peter Maydell
On Thu, 23 Jan 2020 at 15:51, Peter Maydell wrote: > > On Thu, 23 Jan 2020 at 05:25, Guenter Roeck wrote: > > > > Replace debug logging code with tracing. > > > > Reviewed-by: Peter Maydell > > Signed-off-by: Guenter Roeck > > This turns out not to compile on OSX, which is a bit > stricter abou

Re: [PATCH v3 1/8] dma/pl330: Convert to support tracing

2020-01-23 Thread Peter Maydell
On Thu, 23 Jan 2020 at 05:25, Guenter Roeck wrote: > > Replace debug logging code with tracing. > > Reviewed-by: Peter Maydell > Signed-off-by: Guenter Roeck This turns out not to compile on OSX, which is a bit stricter about format strings: These two: > +pl330_dmald(uint32_t chan, uint32_t a

[PATCH v3 1/8] dma/pl330: Convert to support tracing

2020-01-22 Thread Guenter Roeck
Replace debug logging code with tracing. Reviewed-by: Peter Maydell Signed-off-by: Guenter Roeck --- v3: Added Reviewed-by: tag v2: Make call to pl330_hexdump() conditional hw/dma/pl330.c | 88 - hw/dma/trace-events | 24 + 2 files