Re: [PATCH v3 1/5] Refactor i.MX6UL processor code

2023-08-07 Thread Peter Maydell
On Wed, 2 Aug 2023 at 22:09, Jean-Christophe Dubois wrote: > > * Add Addr and size definition for all i.MX6UL devices in i.MX6UL header file. > * Use those newly defined named constants whenever possible. > * Standardize the way we init a familly of unimplemented devices > - SAI > - PWM (add

Re: [PATCH v3 1/5] Refactor i.MX6UL processor code

2023-08-03 Thread Jean-Christophe DUBOIS
Le 02/08/2023 à 23:32, Philippe Mathieu-Daudé a écrit : Hi Jean-Christophe, On 2/8/23 23:08, Jean-Christophe Dubois wrote: * Add Addr and size definition for all i.MX6UL devices in i.MX6UL header file. I'm OK with your patch, but some addr/size are added, while other are changed. It is hard t

Re: [PATCH v3 1/5] Refactor i.MX6UL processor code

2023-08-02 Thread Philippe Mathieu-Daudé
Hi Jean-Christophe, On 2/8/23 23:08, Jean-Christophe Dubois wrote: * Add Addr and size definition for all i.MX6UL devices in i.MX6UL header file. I'm OK with your patch, but some addr/size are added, while other are changed. It is hard to review. Having one patch for changes and another for ad

[PATCH v3 1/5] Refactor i.MX6UL processor code

2023-08-02 Thread Jean-Christophe Dubois
* Add Addr and size definition for all i.MX6UL devices in i.MX6UL header file. * Use those newly defined named constants whenever possible. * Standardize the way we init a familly of unimplemented devices - SAI - PWM (add missing PWM instances) - CAN * Add/rework few comments Signed-off-by: