Re: [PATCH v3 1/4] virtio: skip legacy support check on machine types less than 5.1

2020-09-18 Thread Stefano Garzarella
On Fri, Sep 18, 2020 at 11:13:42AM +0200, Cornelia Huck wrote: > On Fri, 18 Sep 2020 09:47:07 +0200 > Stefano Garzarella wrote: > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > > on") added a check that returns an error if legacy support is on, but the > > device

Re: [PATCH v3 1/4] virtio: skip legacy support check on machine types less than 5.1

2020-09-18 Thread Cornelia Huck
On Fri, 18 Sep 2020 09:47:07 +0200 Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > on") added a check that returns an error if legacy support is on, but the > device is not legacy. s/is not legacy/does not support legacy/ ? > > Unfortuna

[PATCH v3 1/4] virtio: skip legacy support check on machine types less than 5.1

2020-09-18 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a check that returns an error if legacy support is on, but the device is not legacy. Unfortunately some devices were wrongly declared legacy even if they were not (e.g vhost-vsock). To avoid migration issues, we