Re: [PATCH v3 1/4] osdep: Make qemu_madvise() to set errno in all cases

2024-06-03 Thread Akihiko Odaki
On 2024/06/03 19:07, Michal Prívozník wrote: On 6/3/24 10:50, Akihiko Odaki wrote: On 2024/06/03 16:56, Michal Prívozník wrote: On 6/2/24 08:26, Akihiko Odaki wrote: On 2024/06/01 0:46, Philippe Mathieu-Daudé wrote: On 31/5/24 17:10, Michal Privoznik wrote: The unspoken premise of qemu_madvi

Re: [PATCH v3 1/4] osdep: Make qemu_madvise() to set errno in all cases

2024-06-03 Thread Michal Prívozník
On 6/3/24 10:50, Akihiko Odaki wrote: > On 2024/06/03 16:56, Michal Prívozník wrote: >> On 6/2/24 08:26, Akihiko Odaki wrote: >>> On 2024/06/01 0:46, Philippe Mathieu-Daudé wrote: On 31/5/24 17:10, Michal Privoznik wrote: > The unspoken premise of qemu_madvise() is that errno is set on >>>

Re: [PATCH v3 1/4] osdep: Make qemu_madvise() to set errno in all cases

2024-06-03 Thread Akihiko Odaki
On 2024/06/03 16:56, Michal Prívozník wrote: On 6/2/24 08:26, Akihiko Odaki wrote: On 2024/06/01 0:46, Philippe Mathieu-Daudé wrote: On 31/5/24 17:10, Michal Privoznik wrote: The unspoken premise of qemu_madvise() is that errno is set on error. And it is mostly the case except for posix_madvis

Re: [PATCH v3 1/4] osdep: Make qemu_madvise() to set errno in all cases

2024-06-03 Thread Michal Prívozník
On 6/2/24 08:26, Akihiko Odaki wrote: > On 2024/06/01 0:46, Philippe Mathieu-Daudé wrote: >> On 31/5/24 17:10, Michal Privoznik wrote: >>> The unspoken premise of qemu_madvise() is that errno is set on >>> error. And it is mostly the case except for posix_madvise() which >>> is documented to return

Re: [PATCH v3 1/4] osdep: Make qemu_madvise() to set errno in all cases

2024-06-03 Thread Michal Prívozník
On 5/31/24 17:46, Philippe Mathieu-Daudé wrote: > On 31/5/24 17:10, Michal Privoznik wrote: >> The unspoken premise of qemu_madvise() is that errno is set on >> error. And it is mostly the case except for posix_madvise() which >> is documented to return either zero (on success) or a positive >> err

Re: [PATCH v3 1/4] osdep: Make qemu_madvise() to set errno in all cases

2024-06-01 Thread Akihiko Odaki
On 2024/06/01 0:46, Philippe Mathieu-Daudé wrote: On 31/5/24 17:10, Michal Privoznik wrote: The unspoken premise of qemu_madvise() is that errno is set on error. And it is mostly the case except for posix_madvise() which is documented to return either zero (on success) or a positive error number

Re: [PATCH v3 1/4] osdep: Make qemu_madvise() to set errno in all cases

2024-05-31 Thread Philippe Mathieu-Daudé
On 31/5/24 17:10, Michal Privoznik wrote: The unspoken premise of qemu_madvise() is that errno is set on error. And it is mostly the case except for posix_madvise() which is documented to return either zero (on success) or a positive error number. This means, we must set errno ourselves. And whil

[PATCH v3 1/4] osdep: Make qemu_madvise() to set errno in all cases

2024-05-31 Thread Michal Privoznik
The unspoken premise of qemu_madvise() is that errno is set on error. And it is mostly the case except for posix_madvise() which is documented to return either zero (on success) or a positive error number. This means, we must set errno ourselves. And while at it, make the function return a negative