Re: [PATCH v3 1/3] migration/multifd: Ensure we're not given a socket for file migration

2024-03-15 Thread Peter Xu
On Fri, Mar 15, 2024 at 12:20:38AM -0300, Fabiano Rosas wrote: > When doing migration using the fd: URI, QEMU will fetch the file > descriptor passed in via the monitor at > fd_start_outgoing|incoming_migration(), which means the checks at > migration_channels_and_transport_compatible() happen too

[PATCH v3 1/3] migration/multifd: Ensure we're not given a socket for file migration

2024-03-14 Thread Fabiano Rosas
When doing migration using the fd: URI, QEMU will fetch the file descriptor passed in via the monitor at fd_start_outgoing|incoming_migration(), which means the checks at migration_channels_and_transport_compatible() happen too soon and we don't know at that point whether the FD refers to a plain f