Re: [PATCH v3 1/2] qga: Invert logic on return value in main()

2025-02-26 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Tue, Jan 7, 2025 at 4:52 PM Michal Privoznik wrote: > Current logic on return value ('ret' variable) in main() is error > prone. The variable is initialized to EXIT_SUCCESS and then set > to EXIT_FAILURE on error paths. This makes it very easy to forget > to s

[PATCH v3 1/2] qga: Invert logic on return value in main()

2025-01-07 Thread Michal Privoznik
Current logic on return value ('ret' variable) in main() is error prone. The variable is initialized to EXIT_SUCCESS and then set to EXIT_FAILURE on error paths. This makes it very easy to forget to set the variable to indicate error when adding new error path, as is demonstrated by handling of ini