Re: [PATCH v3 1/2] migration: Fix incorrect integer->float conversion caught by clang

2020-01-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Markus Armbruster writes: > > > Juan Quintela writes: > > > >> Markus Armbruster wrote: > >>> From: Fangrui Song > >>> > >>> Clang does not like qmp_migrate_set_downtime()'s code to clamp double > >>> @value to 0..INT64_MAX: > >>> > >>> qemu

Re: [PATCH v3 1/2] migration: Fix incorrect integer->float conversion caught by clang

2020-01-14 Thread Juan Quintela
Markus Armbruster wrote: > Markus Armbruster writes: > >> Juan Quintela writes: >> >>> Markus Armbruster wrote: From: Fangrui Song Clang does not like qmp_migrate_set_downtime()'s code to clamp double @value to 0..INT64_MAX: qemu/migration/migration.c:2038:24:

Re: [PATCH v3 1/2] migration: Fix incorrect integer->float conversion caught by clang

2020-01-14 Thread Markus Armbruster
Markus Armbruster writes: > Juan Quintela writes: > >> Markus Armbruster wrote: >>> From: Fangrui Song >>> >>> Clang does not like qmp_migrate_set_downtime()'s code to clamp double >>> @value to 0..INT64_MAX: >>> >>> qemu/migration/migration.c:2038:24: error: implicit conversion from >>>

Re: [PATCH v3 1/2] migration: Fix incorrect integer->float conversion caught by clang

2019-11-22 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> From: Fangrui Song >> >> Clang does not like qmp_migrate_set_downtime()'s code to clamp double >> @value to 0..INT64_MAX: >> >> qemu/migration/migration.c:2038:24: error: implicit conversion from >> 'long' to 'double' changes value from 9

Re: [PATCH v3 1/2] migration: Fix incorrect integer->float conversion caught by clang

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/22/19 9:00 AM, Markus Armbruster wrote: From: Fangrui Song Clang does not like qmp_migrate_set_downtime()'s code to clamp double @value to 0..INT64_MAX: qemu/migration/migration.c:2038:24: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to

Re: [PATCH v3 1/2] migration: Fix incorrect integer->float conversion caught by clang

2019-11-22 Thread Juan Quintela
Markus Armbruster wrote: > From: Fangrui Song > > Clang does not like qmp_migrate_set_downtime()'s code to clamp double > @value to 0..INT64_MAX: > > qemu/migration/migration.c:2038:24: error: implicit conversion from > 'long' to 'double' changes value from 9223372036854775807 to > 92233720

Re: [PATCH v3 1/2] migration: Fix incorrect integer->float conversion caught by clang

2019-11-22 Thread Richard Henderson
On 11/22/19 9:00 AM, Markus Armbruster wrote: > From: Fangrui Song > > Clang does not like qmp_migrate_set_downtime()'s code to clamp double > @value to 0..INT64_MAX: > > qemu/migration/migration.c:2038:24: error: implicit conversion from > 'long' to 'double' changes value from 922337203685

[PATCH v3 1/2] migration: Fix incorrect integer->float conversion caught by clang

2019-11-22 Thread Markus Armbruster
From: Fangrui Song Clang does not like qmp_migrate_set_downtime()'s code to clamp double @value to 0..INT64_MAX: qemu/migration/migration.c:2038:24: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-floa