Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 12:16:08PM -0500, Peter Xu wrote: > On Tue, Nov 22, 2022 at 10:12:25PM +0530, manish.mishra wrote: > > > > On 22/11/22 10:03 pm, Peter Xu wrote: > > > On Tue, Nov 22, 2022 at 11:29:05AM -0500, Peter Xu wrote: > > > > On Tue, Nov 22, 2022 at 11:10:18AM -0500, Peter Xu wrote:

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Peter Xu
On Tue, Nov 22, 2022 at 10:12:25PM +0530, manish.mishra wrote: > > On 22/11/22 10:03 pm, Peter Xu wrote: > > On Tue, Nov 22, 2022 at 11:29:05AM -0500, Peter Xu wrote: > > > On Tue, Nov 22, 2022 at 11:10:18AM -0500, Peter Xu wrote: > > > > On Tue, Nov 22, 2022 at 09:01:59PM +0530, manish.mishra wro

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread manish.mishra
On 22/11/22 10:03 pm, Peter Xu wrote: On Tue, Nov 22, 2022 at 11:29:05AM -0500, Peter Xu wrote: On Tue, Nov 22, 2022 at 11:10:18AM -0500, Peter Xu wrote: On Tue, Nov 22, 2022 at 09:01:59PM +0530, manish.mishra wrote: On 22/11/22 8:19 pm, Daniel P. Berrangé wrote: On Tue, Nov 22, 2022 at 09:

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Peter Xu
On Tue, Nov 22, 2022 at 11:29:05AM -0500, Peter Xu wrote: > On Tue, Nov 22, 2022 at 11:10:18AM -0500, Peter Xu wrote: > > On Tue, Nov 22, 2022 at 09:01:59PM +0530, manish.mishra wrote: > > > > > > On 22/11/22 8:19 pm, Daniel P. Berrangé wrote: > > > > On Tue, Nov 22, 2022 at 09:41:01AM -0500, Pete

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Peter Xu
On Tue, Nov 22, 2022 at 11:10:18AM -0500, Peter Xu wrote: > On Tue, Nov 22, 2022 at 09:01:59PM +0530, manish.mishra wrote: > > > > On 22/11/22 8:19 pm, Daniel P. Berrangé wrote: > > > On Tue, Nov 22, 2022 at 09:41:01AM -0500, Peter Xu wrote: > > > > On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Peter Xu
On Tue, Nov 22, 2022 at 09:01:59PM +0530, manish.mishra wrote: > > On 22/11/22 8:19 pm, Daniel P. Berrangé wrote: > > On Tue, Nov 22, 2022 at 09:41:01AM -0500, Peter Xu wrote: > > > On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote: > > > > On 22/11/22 2:30 pm, Daniel P. Berrangé wrote

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread manish.mishra
On 22/11/22 8:19 pm, Daniel P. Berrangé wrote: On Tue, Nov 22, 2022 at 09:41:01AM -0500, Peter Xu wrote: On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote: On 22/11/22 2:30 pm, Daniel P. Berrangé wrote: On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote: MSG_PEEK reads

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 09:41:01AM -0500, Peter Xu wrote: > On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote: > > > > On 22/11/22 2:30 pm, Daniel P. Berrangé wrote: > > > On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote: > > > > MSG_PEEK reads from the peek of channel, Th

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Peter Xu
On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote: > > On 22/11/22 2:30 pm, Daniel P. Berrangé wrote: > > On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote: > > > MSG_PEEK reads from the peek of channel, The data is treated as > > > unread and the next read shall still retu

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 03:43:55PM +0530, manish.mishra wrote: > > On 22/11/22 3:23 pm, Daniel P. Berrangé wrote: > > On Tue, Nov 22, 2022 at 03:10:53PM +0530, manish.mishra wrote: > > > On 22/11/22 2:59 pm, Daniel P. Berrangé wrote: > > > > On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread manish.mishra
On 22/11/22 3:23 pm, Daniel P. Berrangé wrote: On Tue, Nov 22, 2022 at 03:10:53PM +0530, manish.mishra wrote: On 22/11/22 2:59 pm, Daniel P. Berrangé wrote: On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote: On 22/11/22 2:30 pm, Daniel P. Berrangé wrote: On Sat, Nov 19, 2022 at

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 03:10:53PM +0530, manish.mishra wrote: > > On 22/11/22 2:59 pm, Daniel P. Berrangé wrote: > > On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote: > > > On 22/11/22 2:30 pm, Daniel P. Berrangé wrote: > > > > On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread manish.mishra
On 22/11/22 2:59 pm, Daniel P. Berrangé wrote: On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote: On 22/11/22 2:30 pm, Daniel P. Berrangé wrote: On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote: MSG_PEEK reads from the peek of channel, The data is treated as unread a

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote: > > On 22/11/22 2:30 pm, Daniel P. Berrangé wrote: > > On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote: > > > MSG_PEEK reads from the peek of channel, The data is treated as > > > unread and the next read shall still retu

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread manish.mishra
On 22/11/22 2:30 pm, Daniel P. Berrangé wrote: On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote: MSG_PEEK reads from the peek of channel, The data is treated as unread and the next read shall still return this data. This support is currently added only for socket class. Extra para

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote: > MSG_PEEK reads from the peek of channel, The data is treated as > unread and the next read shall still return this data. This > support is currently added only for socket class. Extra parameter > 'flags' is added to io_readv calls to

[PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-19 Thread manish.mishra
MSG_PEEK reads from the peek of channel, The data is treated as unread and the next read shall still return this data. This support is currently added only for socket class. Extra parameter 'flags' is added to io_readv calls to pass extra read flags like MSG_PEEK. Suggested-by: Daniel P. Berrangé