Re: [PATCH v3 1/2] hw/i386: Attach CPUs to machine

On 5/2/22 11:32, Philippe Mathieu-Daudé wrote: +Igor On 5/2/22 10:21, Paolo Bonzini wrote: It broke check-system-debian in CI. OK. This is odd because I am using Ubuntu 20.04 x86_64 host and can not reproduce. I'll investigate. OK I could reproduce using the Docker image pulled from registr

Re: [PATCH v3 1/2] hw/i386: Attach CPUs to machine

+Igor On 5/2/22 10:21, Paolo Bonzini wrote: It broke check-system-debian in CI. OK. This is odd because I am using Ubuntu 20.04 x86_64 host and can not reproduce. I'll investigate. Il ven 4 feb 2022, 20:31 Philippe Mathieu-Daudé > ha scritto: On 4/2/22 18:59, Pao

Re: [PATCH v3 1/2] hw/i386: Attach CPUs to machine

It broke check-system-debian in CI. Paolo Il ven 4 feb 2022, 20:31 Philippe Mathieu-Daudé ha scritto: > On 4/2/22 18:59, Paolo Bonzini wrote: > > This is causing breakage in the acpi-tables-test, sorry. > > $ make check-qtest-x86_64 > > Ok: 49 > Expected Fail: 0 > Fail:

Re: [PATCH v3 1/2] hw/i386: Attach CPUs to machine

On 4/2/22 18:59, Paolo Bonzini wrote: This is causing breakage in the acpi-tables-test, sorry. $ make check-qtest-x86_64 Ok: 49 Expected Fail: 0 Fail: 0 Unexpected Pass:0 Skipped:7 Timeout:0 $ make check-qtest-i386 Ok:

Re: [PATCH v3 1/2] hw/i386: Attach CPUs to machine

This is causing breakage in the acpi-tables-test, sorry. Paolo Il mar 1 feb 2022, 00:35 Philippe Mathieu-Daudé ha scritto: > Previously CPUs were exposed in the QOM tree at a path > > /machine/unattached/device[nn] > > where the 'nn' of the first CPU is usually zero, but can > vary depending

Re: [PATCH v3 1/2] hw/i386: Attach CPUs to machine

Cc libvir-list since this will (intentionally) break compatibility with current libvirt code that looks for "/machine/unattached/device[0]" in the assumption it is the first CPU. On Tue, Feb 01, 2022 at 12:35:06AM +0100, Philippe Mathieu-Daudé wrote: > Previously CPUs were exposed in the QOM tree

[PATCH v3 1/2] hw/i386: Attach CPUs to machine

Previously CPUs were exposed in the QOM tree at a path /machine/unattached/device[nn] where the 'nn' of the first CPU is usually zero, but can vary depending on what devices were already created. With this change the CPUs are now at /machine/cpu[nn] where the 'nn' of the first CPU is alway