Re: [PATCH v3 1/2] coreaudio: Commit the result of init in the end

2025-01-16 Thread Christian Schoenebeck
On Thursday, January 16, 2025 6:17:46 AM CET Akihiko Odaki wrote: > On 2025/01/16 2:10, Christian Schoenebeck wrote: > > On Wednesday, January 15, 2025 4:37:28 PM CET Akihiko Odaki wrote: > >> On 2025/01/16 0:14, Christian Schoenebeck wrote: > >>> On Wednesday, January 15, 2025 1:06:55 PM CET Akihi

Re: [PATCH v3 1/2] coreaudio: Commit the result of init in the end

2025-01-15 Thread Akihiko Odaki
On 2025/01/16 2:10, Christian Schoenebeck wrote: On Wednesday, January 15, 2025 4:37:28 PM CET Akihiko Odaki wrote: On 2025/01/16 0:14, Christian Schoenebeck wrote: On Wednesday, January 15, 2025 1:06:55 PM CET Akihiko Odaki wrote: init_out_device may only commit some part of the result and le

Re: [PATCH v3 1/2] coreaudio: Commit the result of init in the end

2025-01-15 Thread Christian Schoenebeck
On Wednesday, January 15, 2025 4:37:28 PM CET Akihiko Odaki wrote: > On 2025/01/16 0:14, Christian Schoenebeck wrote: > > On Wednesday, January 15, 2025 1:06:55 PM CET Akihiko Odaki wrote: > >> init_out_device may only commit some part of the result and leave the > >> state inconsistent when it enc

Re: [PATCH v3 1/2] coreaudio: Commit the result of init in the end

2025-01-15 Thread Akihiko Odaki
On 2025/01/16 0:14, Christian Schoenebeck wrote: On Wednesday, January 15, 2025 1:06:55 PM CET Akihiko Odaki wrote: init_out_device may only commit some part of the result and leave the state inconsistent when it encounters an error. Commit the result in the end of the function so that it commit

Re: [PATCH v3 1/2] coreaudio: Commit the result of init in the end

2025-01-15 Thread Christian Schoenebeck
On Wednesday, January 15, 2025 1:06:55 PM CET Akihiko Odaki wrote: > init_out_device may only commit some part of the result and leave the > state inconsistent when it encounters an error. Commit the result in > the end of the function so that it commits the result iff it sees no Typo "if". > err

[PATCH v3 1/2] coreaudio: Commit the result of init in the end

2025-01-15 Thread Akihiko Odaki
init_out_device may only commit some part of the result and leave the state inconsistent when it encounters an error. Commit the result in the end of the function so that it commits the result iff it sees no error. With this change, handle_voice_change can rely on core->outputDeviceID to know whet