Re: Re: [PATCH v3 1/1] hw/riscv: Fix max size limit when put initrd to RAM

2023-04-06 Thread Hang Xu
Hi, On 2023-04-05 13:53,  Alistair Francis wrote: >       >On Mon, Mar 13, 2023 at 11:12 PM Hang Xu wrote: >> >> Because the starting address of ram is not necessarily 0, >> the remaining free space in ram is >> ram_size - (start - ram_base) instead of ram_size-start. > >I think this could be clea

Re: [PATCH v3 1/1] hw/riscv: Fix max size limit when put initrd to RAM

2023-04-05 Thread Daniel Henrique Barboza
On 4/5/23 02:53, Alistair Francis wrote: On Mon, Mar 13, 2023 at 11:12 PM Hang Xu wrote: Because the starting address of ram is not necessarily 0, the remaining free space in ram is ram_size - (start - ram_base) instead of ram_size-start. I think this could be clearer. It's not clear here

Re: [PATCH v3 1/1] hw/riscv: Fix max size limit when put initrd to RAM

2023-04-04 Thread Alistair Francis
On Mon, Mar 13, 2023 at 11:12 PM Hang Xu wrote: > > Because the starting address of ram is not necessarily 0, > the remaining free space in ram is > ram_size - (start - ram_base) instead of ram_size-start. I think this could be clearer. It's not clear here that you mean the free space after the k

Re: [PATCH v3 1/1] hw/riscv: Fix max size limit when put initrd to RAM

2023-03-13 Thread Daniel Henrique Barboza
On 3/13/23 12:49, Anup Patel wrote: On Mon, Mar 13, 2023 at 7:49 AM Hang Xu wrote: Because the starting address of ram is not necessarily 0, the remaining free space in ram is ram_size - (start - ram_base) instead of ram_size-start. Signed-off-by: Hang Xu What happens in-case a platform

Re: [PATCH v3 1/1] hw/riscv: Fix max size limit when put initrd to RAM

2023-03-13 Thread Anup Patel
On Mon, Mar 13, 2023 at 7:49 AM Hang Xu wrote: > > Because the starting address of ram is not necessarily 0, > the remaining free space in ram is > ram_size - (start - ram_base) instead of ram_size-start. > > Signed-off-by: Hang Xu What happens in-case a platform has multiple RAM banks ? Regard

[PATCH v3 1/1] hw/riscv: Fix max size limit when put initrd to RAM

2023-03-13 Thread Hang Xu
Because the starting address of ram is not necessarily 0, the remaining free space in ram is ram_size - (start - ram_base) instead of ram_size-start. Signed-off-by: Hang Xu --- hw/riscv/boot.c| 19 +-- hw/riscv/microchip_pfsoc.c | 5 - hw/riscv/opentitan.c

Re: [PATCH v3 1/1] hw/riscv: Fix max size limit when put initrd to RAM

2023-03-13 Thread Daniel Henrique Barboza
On 3/12/23 23:18, Hang Xu wrote: Because the starting address of ram is not necessarily 0, the remaining free space in ram is ram_size - (start - ram_base) instead of ram_size-start. Signed-off-by: Hang Xu --- Reviewed-by: Daniel Henrique Barboza hw/riscv/boot.c| 19 ++