Re: [PATCH v3 1/1] acpi: Consolidate the handling of OEM ID and OEM Table ID fields

2021-03-23 Thread Marian Postevca
"Michael S. Tsirkin" writes: >> +#include "qemu/cutils.h" >> + >> +#define ACPI_BUILD_APPNAME6 "BOCHS " >> +#define ACPI_BUILD_APPNAME8 "BXPC" > > A single user for each of these now ... drop the defines? > Unfortunately ACPI_BUILD_APPNAME8 is still used in build_header() in aml-build.c, and

Re: [PATCH v3 1/1] acpi: Consolidate the handling of OEM ID and OEM Table ID fields

2021-03-22 Thread Michael S. Tsirkin
On Mon, Mar 22, 2021 at 11:55:54PM +0200, Marian Postevca wrote: > Introduces structure AcpiBuildOem to hold the value of OEM fields and > uses dedicated macros to initialize/set the values. > Unnecessary dynamically allocated OEM fields are re-factored to static > allocation. > > Signed-off-by: M

[PATCH v3 1/1] acpi: Consolidate the handling of OEM ID and OEM Table ID fields

2021-03-22 Thread Marian Postevca
Introduces structure AcpiBuildOem to hold the value of OEM fields and uses dedicated macros to initialize/set the values. Unnecessary dynamically allocated OEM fields are re-factored to static allocation. Signed-off-by: Marian Postevca --- hw/acpi/hmat.h | 2 +- hw/i386/acpi-c