RE: [PATCH v3 09/47] igb: Always copy ethernet header

2023-04-24 Thread Sriram Yagnaraman
Beraldo Leal ; Cleber Rosa > ; Laurent Vivier ; Paolo Bonzini > ; qemu-devel@nongnu.org; Tomasz Dzieciol > ; Akihiko Odaki > > Subject: [PATCH v3 09/47] igb: Always copy ethernet header > > igb_receive_internal() used to check the iov length to determine copy the iovs > to a conti

[PATCH v3 09/47] igb: Always copy ethernet header

2023-04-22 Thread Akihiko Odaki
igb_receive_internal() used to check the iov length to determine copy the iovs to a contiguous buffer, but the check is flawed in two ways: - It does not ensure that iovcnt > 0. - It does not take virtio-net header into consideration. The size of this copy is just 22 octets, which can be even less