Re: [PATCH v3 09/33] block: Add generic bdrv_inherited_options()

2020-05-07 Thread Max Reitz
On 07.05.20 13:19, Kevin Wolf wrote: > Am 07.05.2020 um 10:49 hat Max Reitz geschrieben: >> On 06.05.20 12:37, Kevin Wolf wrote: >>> Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: +if (role & BDRV_CHILD_COW) { +/* backing files are always opened read-only */ >>> >>> Not "al

Re: [PATCH v3 09/33] block: Add generic bdrv_inherited_options()

2020-05-07 Thread Kevin Wolf
Am 07.05.2020 um 10:49 hat Max Reitz geschrieben: > On 06.05.20 12:37, Kevin Wolf wrote: > > Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > >> +if (role & BDRV_CHILD_COW) { > >> +/* backing files are always opened read-only */ > > > > Not "always", just by default. > > OK. I jus

Re: [PATCH v3 09/33] block: Add generic bdrv_inherited_options()

2020-05-07 Thread Max Reitz
On 06.05.20 15:11, Kevin Wolf wrote: > Am 06.05.2020 um 12:37 hat Kevin Wolf geschrieben: >> Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: >>> After the series this patch belongs to, we want to have a common >>> BdrvChildClass that encompasses all of child_file, child_format, and >>> child_back

Re: [PATCH v3 09/33] block: Add generic bdrv_inherited_options()

2020-05-07 Thread Max Reitz
On 06.05.20 12:37, Kevin Wolf wrote: > Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: >> After the series this patch belongs to, we want to have a common >> BdrvChildClass that encompasses all of child_file, child_format, and >> child_backing. Such a single class needs a single .inherit_options

Re: [PATCH v3 09/33] block: Add generic bdrv_inherited_options()

2020-05-06 Thread Kevin Wolf
Am 06.05.2020 um 12:37 hat Kevin Wolf geschrieben: > Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > > After the series this patch belongs to, we want to have a common > > BdrvChildClass that encompasses all of child_file, child_format, and > > child_backing. Such a single class needs a single

Re: [PATCH v3 09/33] block: Add generic bdrv_inherited_options()

2020-05-06 Thread Kevin Wolf
Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: > After the series this patch belongs to, we want to have a common > BdrvChildClass that encompasses all of child_file, child_format, and > child_backing. Such a single class needs a single .inherit_options() > implementation, and this patch introd

[PATCH v3 09/33] block: Add generic bdrv_inherited_options()

2020-02-18 Thread Max Reitz
After the series this patch belongs to, we want to have a common BdrvChildClass that encompasses all of child_file, child_format, and child_backing. Such a single class needs a single .inherit_options() implementation, and this patch introduces it. The next patch will show how the existing implem