Re: [PATCH v3 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros

2020-12-15 Thread Alistair Francis
On Tue, Dec 15, 2020 at 7:13 AM Richard Henderson wrote: > > On 12/15/20 3:38 AM, Bin Meng wrote: > >> #if defined(TARGET_RISCV64) > >> -uint64_t helper_fcvt_l_s(CPURISCVState *env, uint64_t rs1) > >> +target_ulong helper_fcvt_l_s(CPURISCVState *env, uint64_t rs1) > >> { > >> float32 frs1 =

Re: [PATCH v3 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros

2020-12-15 Thread Richard Henderson
On 12/15/20 3:38 AM, Bin Meng wrote: >> #if defined(TARGET_RISCV64) >> -uint64_t helper_fcvt_l_s(CPURISCVState *env, uint64_t rs1) >> +target_ulong helper_fcvt_l_s(CPURISCVState *env, uint64_t rs1) >> { >> float32 frs1 = check_nanbox_s(rs1); >> return float32_to_int64(frs1, &env->fp_sta

Re: [PATCH v3 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros

2020-12-15 Thread Bin Meng
Hi Alistair, On Tue, Dec 15, 2020 at 4:34 AM Alistair Francis wrote: > > The helper functions defined in helper.h specify that the argument is of I can't find the helper.h that declare these functions? > type target_long. Let's change the implementation to match the header > definition. > > Sig

[PATCH v3 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros

2020-12-14 Thread Alistair Francis
The helper functions defined in helper.h specify that the argument is of type target_long. Let's change the implementation to match the header definition. Signed-off-by: Alistair Francis --- target/riscv/fpu_helper.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --