Re: [PATCH v3 08/14] tcg/arm: Simplify usage of encode_imm

2021-08-20 Thread Peter Maydell
On Wed, 18 Aug 2021 at 22:38, Richard Henderson wrote: > > We have already computed the rotated value of the imm8 > portion of the complete imm12 encoding. No sense leaving > the combination of rot + rotation to the caller. > > Create an encode_imm12_nofail helper that performs an assert. > > Thi

[PATCH v3 08/14] tcg/arm: Simplify usage of encode_imm

2021-08-18 Thread Richard Henderson
We have already computed the rotated value of the imm8 portion of the complete imm12 encoding. No sense leaving the combination of rot + rotation to the caller. Create an encode_imm12_nofail helper that performs an assert. This removes the final use of the local "rotl" function, which duplicated