Re: [PATCH v3 07/30] target/mips: Turn printfpr() macro into a proper function

2021-04-19 Thread Richard Henderson
On 4/19/21 12:18 PM, Philippe Mathieu-Daudé wrote: +static void fpu_dump_fpr(fpr_t *fpr, FILE *f, bool is_fpu64) If you're going to use bool here, static void fpu_dump_state(CPUMIPSState *env, FILE *f, int flags) { int i; int is_fpu64 = !!(env->hflags & MIPS_HFLAG_F64); ...

[PATCH v3 07/30] target/mips: Turn printfpr() macro into a proper function

2021-04-19 Thread Philippe Mathieu-Daudé
Turn printfpr() macro into a proper function: fpu_dump_fpr(). Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.c | 48 ++- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/target/mips/cpu.c b/tar