Re: [PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-02-17 Thread Niek Linnenbank
On Wed, Feb 12, 2020 at 11:48 PM Philippe Mathieu-Daudé wrote: > )-.On Wed, Feb 12, 2020 at 10:31 PM Niek Linnenbank > wrote: > > > > Hi Corey, > > > > On Thu, Feb 6, 2020 at 10:09 PM Niek Linnenbank < > nieklinnenb...@gmail.com> wrote: > >> > >> Hi Corey, > >> > >> On Mon, Feb 3, 2020 at 2:10 P

Re: [PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-02-12 Thread Philippe Mathieu-Daudé
)-.On Wed, Feb 12, 2020 at 10:31 PM Niek Linnenbank wrote: > > Hi Corey, > > On Thu, Feb 6, 2020 at 10:09 PM Niek Linnenbank > wrote: >> >> Hi Corey, >> >> On Mon, Feb 3, 2020 at 2:10 PM Corey Minyard wrote: >>> >>> On Sun, Feb 02, 2020 at 10:27:49PM +0100, Niek Linnenbank wrote: >>> > Hi Corey

Re: [PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-02-12 Thread Niek Linnenbank
Hi Corey, On Thu, Feb 6, 2020 at 10:09 PM Niek Linnenbank wrote: > Hi Corey, > > On Mon, Feb 3, 2020 at 2:10 PM Corey Minyard wrote: > >> On Sun, Feb 02, 2020 at 10:27:49PM +0100, Niek Linnenbank wrote: >> > Hi Corey, >> > >> > Thanks for reviewing! >> > >> > On Mon, Jan 20, 2020 at 6:59 PM Cor

Re: [PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-02-06 Thread Niek Linnenbank
Hi Corey, On Mon, Feb 3, 2020 at 2:10 PM Corey Minyard wrote: > On Sun, Feb 02, 2020 at 10:27:49PM +0100, Niek Linnenbank wrote: > > Hi Corey, > > > > Thanks for reviewing! > > > > On Mon, Jan 20, 2020 at 6:59 PM Corey Minyard > wrote: > > > > > On Sat, Jan 18, 2020 at 04:25:08PM +0100, Philipp

Re: [PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-02-03 Thread Corey Minyard
On Sun, Feb 02, 2020 at 10:27:49PM +0100, Niek Linnenbank wrote: > Hi Corey, > > Thanks for reviewing! > > On Mon, Jan 20, 2020 at 6:59 PM Corey Minyard wrote: > > > On Sat, Jan 18, 2020 at 04:25:08PM +0100, Philippe Mathieu-Daudé wrote: > > > Cc'ing Corey/David for good advices about using UUI

Re: [PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-02-02 Thread Niek Linnenbank
Hi Corey, Thanks for reviewing! On Mon, Jan 20, 2020 at 6:59 PM Corey Minyard wrote: > On Sat, Jan 18, 2020 at 04:25:08PM +0100, Philippe Mathieu-Daudé wrote: > > Cc'ing Corey/David for good advices about using UUID. > > Is there any reason you didn't use the built-in qemu UUID for this? It >

Re: [PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-01-20 Thread Corey Minyard
On Sat, Jan 18, 2020 at 04:25:08PM +0100, Philippe Mathieu-Daudé wrote: > Cc'ing Corey/David for good advices about using UUID. Is there any reason you didn't use the built-in qemu UUID for this? It would simplify things in general. Also, in case no one else say, you have tabs in your code that

Re: [PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-01-18 Thread Philippe Mathieu-Daudé
Cc'ing Corey/David for good advices about using UUID. On 1/8/20 9:00 PM, Niek Linnenbank wrote: The Security Identifier device found in various Allwinner System on Chip designs gives applications a per-board unique identifier. This commit adds support for the Allwinner Security Identifier using

[PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-01-08 Thread Niek Linnenbank
The Security Identifier device found in various Allwinner System on Chip designs gives applications a per-board unique identifier. This commit adds support for the Allwinner Security Identifier using a 128-bit UUID value as input. Signed-off-by: Niek Linnenbank --- include/hw/arm/allwinner-h3.h