Re: [PATCH v3 07/12] hw/arm/virt: Move post cpu realize check into its own function

2020-09-15 Thread Haibo Xu
On Tue, 15 Sep 2020 at 15:31, Andrew Jones wrote: > > On Tue, Sep 15, 2020 at 03:03:49PM +0800, Haibo Xu wrote: > > On Tue, 15 Sep 2020 at 14:22, Andrew Jones wrote: > > > > > > On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote: > > > > From: Andrew Jones > > > > > > > > We'll add more to

Re: [PATCH v3 07/12] hw/arm/virt: Move post cpu realize check into its own function

2020-09-15 Thread Andrew Jones
On Tue, Sep 15, 2020 at 03:03:49PM +0800, Haibo Xu wrote: > On Tue, 15 Sep 2020 at 14:22, Andrew Jones wrote: > > > > On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote: > > > From: Andrew Jones > > > > > > We'll add more to this new function in coming patches so we also > > > state the gic

Re: [PATCH v3 07/12] hw/arm/virt: Move post cpu realize check into its own function

2020-09-15 Thread Haibo Xu
On Tue, 15 Sep 2020 at 14:22, Andrew Jones wrote: > > On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote: > > From: Andrew Jones > > > > We'll add more to this new function in coming patches so we also > > state the gic must be created and call it below create_gic(). > > > > No functional c

Re: [PATCH v3 07/12] hw/arm/virt: Move post cpu realize check into its own function

2020-09-14 Thread Andrew Jones
On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote: > From: Andrew Jones > > We'll add more to this new function in coming patches so we also > state the gic must be created and call it below create_gic(). > > No functional change intended. > > Signed-off-by: Andrew Jones > Reviewed-by:

[PATCH v3 07/12] hw/arm/virt: Move post cpu realize check into its own function

2020-09-14 Thread Haibo Xu
From: Andrew Jones We'll add more to this new function in coming patches so we also state the gic must be created and call it below create_gic(). No functional change intended. Signed-off-by: Andrew Jones Reviewed-by: Peter Maydell --- hw/arm/virt.c | 38 ++---