Re: [PATCH v3 06/47] igb: Clear IMS bits when committing ICR access

2023-04-24 Thread Akihiko Odaki
; Beraldo Leal ; Cleber Rosa ; Laurent Vivier ; Paolo Bonzini ; qemu-devel@nongnu.org; Tomasz Dzieciol Subject: Re: [PATCH v3 06/47] igb: Clear IMS bits when committing ICR access On 2023/04/24 18:29, Sriram Yagnaraman wrote: -Original Message- From: Akihiko Odaki Sent: Sunday, 23 April 2023

RE: [PATCH v3 06/47] igb: Clear IMS bits when committing ICR access

2023-04-24 Thread Sriram Yagnaraman
eraldo Leal ; > Cleber Rosa ; Laurent Vivier ; Paolo > Bonzini ; qemu-devel@nongnu.org; Tomasz Dzieciol > > Subject: Re: [PATCH v3 06/47] igb: Clear IMS bits when committing ICR access > > On 2023/04/24 18:29, Sriram Yagnaraman wrote: > >> -Original Message- > >&

Re: [PATCH v3 06/47] igb: Clear IMS bits when committing ICR access

2023-04-24 Thread Akihiko Odaki
Leal ; Cleber Rosa ; Laurent Vivier ; Paolo Bonzini ; qemu-devel@nongnu.org; Tomasz Dzieciol ; Akihiko Odaki Subject: [PATCH v3 06/47] igb: Clear IMS bits when committing ICR access The datasheet says contradicting statements regarding ICR accesses so it is not reliable to determine the behavior

RE: [PATCH v3 06/47] igb: Clear IMS bits when committing ICR access

2023-04-24 Thread Sriram Yagnaraman
l ; Cleber Rosa > ; Laurent Vivier ; Paolo Bonzini > ; qemu-devel@nongnu.org; Tomasz Dzieciol > ; Akihiko Odaki > > Subject: [PATCH v3 06/47] igb: Clear IMS bits when committing ICR access > > The datasheet says contradicting statements regarding ICR accesses so it is &

[PATCH v3 06/47] igb: Clear IMS bits when committing ICR access

2023-04-22 Thread Akihiko Odaki
The datasheet says contradicting statements regarding ICR accesses so it is not reliable to determine the behavior of ICR accesses. However, e1000e does clear IMS bits when reading ICR accesses and Linux also expects ICR accesses will clear IMS bits according to: https://git.kernel.org/pub/scm/linu