Re: [PATCH v3 05/17] qapi: pass QAPISchemaModule to visit_module instead of str

2021-01-20 Thread Markus Armbruster
John Snow writes: > On 1/20/21 11:02 AM, Eric Blake wrote: >> On 1/20/21 6:07 AM, Markus Armbruster wrote: >>> John Snow writes: >>> Modify visit_module to pass the module itself instead of just its name. This allows for future patches to centralize some module-interrogation behav

Re: [PATCH v3 05/17] qapi: pass QAPISchemaModule to visit_module instead of str

2021-01-20 Thread Markus Armbruster
John Snow writes: > On 1/20/21 7:07 AM, Markus Armbruster wrote: >> John Snow writes: [...] >>> diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py >>> index e03abcbb959..f754f675d66 100644 >>> --- a/docs/sphinx/qapidoc.py >>> +++ b/docs/sphinx/qapidoc.py >>> @@ -463,11 +463,11 @@ def _

Re: [PATCH v3 05/17] qapi: pass QAPISchemaModule to visit_module instead of str

2021-01-20 Thread John Snow
On 1/20/21 11:02 AM, Eric Blake wrote: On 1/20/21 6:07 AM, Markus Armbruster wrote: John Snow writes: Modify visit_module to pass the module itself instead of just its name. This allows for future patches to centralize some module-interrogation behavior within the QAPISchemaModule class itsel

Re: [PATCH v3 05/17] qapi: pass QAPISchemaModule to visit_module instead of str

2021-01-20 Thread Eric Blake
On 1/20/21 6:07 AM, Markus Armbruster wrote: > John Snow writes: > >> Modify visit_module to pass the module itself instead of just its >> name. This allows for future patches to centralize some >> module-interrogation behavior within the QAPISchemaModule class itself, >> cutting down on duplicat

Re: [PATCH v3 05/17] qapi: pass QAPISchemaModule to visit_module instead of str

2021-01-20 Thread John Snow
On 1/20/21 7:07 AM, Markus Armbruster wrote: John Snow writes: Modify visit_module to pass the module itself instead of just its name. This allows for future patches to centralize some module-interrogation behavior within the QAPISchemaModule class itself, cutting down on duplication between g

Re: [PATCH v3 05/17] qapi: pass QAPISchemaModule to visit_module instead of str

2021-01-20 Thread Markus Armbruster
John Snow writes: > Modify visit_module to pass the module itself instead of just its > name. This allows for future patches to centralize some > module-interrogation behavior within the QAPISchemaModule class itself, > cutting down on duplication between gen.py and schema.py. We've been tempted

[PATCH v3 05/17] qapi: pass QAPISchemaModule to visit_module instead of str

2021-01-19 Thread John Snow
Modify visit_module to pass the module itself instead of just its name. This allows for future patches to centralize some module-interrogation behavior within the QAPISchemaModule class itself, cutting down on duplication between gen.py and schema.py. Signed-off-by: John Snow --- docs/sphinx/qap