Re: [PATCH v3 04/33] chardev: generate an internal id when none given

2019-11-18 Thread Marc-André Lureau
Hi On Mon, Nov 18, 2019 at 6:12 PM Peter Maydell wrote: > > On Wed, 23 Oct 2019 at 18:33, Marc-André Lureau > wrote: > > > > Internally, qemu may create chardev without ID. Those will not be > > looked up with qemu_chr_find(), which prevents using qdev_prop_set_chr(). > > > > Use id_generate(),

Re: [PATCH v3 04/33] chardev: generate an internal id when none given

2019-11-18 Thread Peter Maydell
On Wed, 23 Oct 2019 at 18:33, Marc-André Lureau wrote: > > Internally, qemu may create chardev without ID. Those will not be > looked up with qemu_chr_find(), which prevents using qdev_prop_set_chr(). > > Use id_generate(), to generate an internal name (prefixed with #), so > no conflict exist wit

[PATCH v3 04/33] chardev: generate an internal id when none given

2019-10-23 Thread Marc-André Lureau
Internally, qemu may create chardev without ID. Those will not be looked up with qemu_chr_find(), which prevents using qdev_prop_set_chr(). Use id_generate(), to generate an internal name (prefixed with #), so no conflict exist with user-named chardev. Signed-off-by: Marc-André Lureau --- chard