Re: [PATCH v3 04/15] vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any

2023-10-04 Thread Eric Auger
Hi Cédric, On 10/3/23 16:53, Cédric Le Goater wrote: > On 10/3/23 12:14, Eric Auger wrote: >> In the VFIO_SPAPR_TCE_v2_IOMMU container case, when >> KVM_SET_DEVICE_ATTR fails, we currently don't propagate the >> error as we do on the vfio_spapr_create_window() failure >> case. Let's align the code

Re: [PATCH v3 04/15] vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any

2023-10-03 Thread Cédric Le Goater
On 10/3/23 12:14, Eric Auger wrote: In the VFIO_SPAPR_TCE_v2_IOMMU container case, when KVM_SET_DEVICE_ATTR fails, we currently don't propagate the error as we do on the vfio_spapr_create_window() failure case. Let's align the code. Take the opportunity to reword the error message and make it mor

[PATCH v3 04/15] vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any

2023-10-03 Thread Eric Auger
In the VFIO_SPAPR_TCE_v2_IOMMU container case, when KVM_SET_DEVICE_ATTR fails, we currently don't propagate the error as we do on the vfio_spapr_create_window() failure case. Let's align the code. Take the opportunity to reword the error message and make it more explicit. Signed-off-by: Eric Auger