Re: [PATCH v3 04/13] vfio/common: Add VFIOBitmap and alloc function

2023-03-06 Thread Joao Martins
On 06/03/2023 13:20, Cédric Le Goater wrote: > On 3/4/23 02:43, Joao Martins wrote: >> From: Avihai Horon >> >> There are already two places where dirty page bitmap allocation and >> calculations are done in open code. With device dirty page tracking >> being added in next patches, there are go

Re: [PATCH v3 04/13] vfio/common: Add VFIOBitmap and alloc function

2023-03-06 Thread Cédric Le Goater
On 3/4/23 02:43, Joao Martins wrote: From: Avihai Horon There are already two places where dirty page bitmap allocation and calculations are done in open code. With device dirty page tracking being added in next patches, there are going to be even more places. To avoid code duplication, introd

[PATCH v3 04/13] vfio/common: Add VFIOBitmap and alloc function

2023-03-03 Thread Joao Martins
From: Avihai Horon There are already two places where dirty page bitmap allocation and calculations are done in open code. With device dirty page tracking being added in next patches, there are going to be even more places. To avoid code duplication, introduce VFIOBitmap struct and corresponding