Re: [PATCH v3 02/27] util/hexdump: Remove ascii parameter from qemu_hexdump_line

2024-06-03 Thread Philippe Mathieu-Daudé
On 12/4/24 09:33, Richard Henderson wrote: Split out asciidump_line as a separate function, local to hexdump.c, for use by qemu_hexdump. Use "%-*s" to generate the alignment between the hex and the ascii, rather than explicit spaces. Signed-off-by: Richard Henderson --- include/qemu/cutils.h

Re: [PATCH v3 02/27] util/hexdump: Remove ascii parameter from qemu_hexdump_line

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 09:33, Richard Henderson wrote: Split out asciidump_line as a separate function, local to hexdump.c, for use by qemu_hexdump. Use "%-*s" to generate the alignment between the hex and the ascii, rather than explicit spaces. Signed-off-by: Richard Henderson --- include/qemu/cutils.h

[PATCH v3 02/27] util/hexdump: Remove ascii parameter from qemu_hexdump_line

2024-04-12 Thread Richard Henderson
Split out asciidump_line as a separate function, local to hexdump.c, for use by qemu_hexdump. Use "%-*s" to generate the alignment between the hex and the ascii, rather than explicit spaces. Signed-off-by: Richard Henderson --- include/qemu/cutils.h | 3 +-- hw/virtio/vhost-vdpa.c | 2 +- ut