Re: [PATCH v3 02/24] tcg/tci: Remove TCG_TARGET_HAS_* ifdefs

2021-01-30 Thread Richard Henderson
On 1/29/21 9:15 PM, Stefan Weil wrote: > If someone decides to use TCG_TARGET_HAS_div2_i64 instead of > TCG_TARGET_HAS_div_i64 with TCI, that lines (in addition to the implementation > of the opcodes) would be needed again. How can you know if those lines are even correct, when there is no infrast

Re: [PATCH v3 02/24] tcg/tci: Remove TCG_TARGET_HAS_* ifdefs

2021-01-29 Thread Stefan Weil
Am 30.01.21 um 07:47 schrieb Richard Henderson: On 1/29/21 1:16 PM, Peter Maydell wrote: On Fri, 29 Jan 2021 at 20:13, Richard Henderson wrote: The opcodes always exist, regardless of whether or not they are enabled. Remove the unnecessary ifdefs. Signed-off-by: Richard Henderson --- tcg

Re: [PATCH v3 02/24] tcg/tci: Remove TCG_TARGET_HAS_* ifdefs

2021-01-29 Thread Richard Henderson
On 1/29/21 1:16 PM, Peter Maydell wrote: > On Fri, 29 Jan 2021 at 20:13, Richard Henderson > wrote: >> >> The opcodes always exist, regardless of whether or not they >> are enabled. Remove the unnecessary ifdefs. >> >> Signed-off-by: Richard Henderson >> --- >> tcg/tci/tcg-target.c.inc | 82 ---

Re: [PATCH v3 02/24] tcg/tci: Remove TCG_TARGET_HAS_* ifdefs

2021-01-29 Thread Peter Maydell
On Fri, 29 Jan 2021 at 20:13, Richard Henderson wrote: > > The opcodes always exist, regardless of whether or not they > are enabled. Remove the unnecessary ifdefs. > > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 82 > 1 file chan

[PATCH v3 02/24] tcg/tci: Remove TCG_TARGET_HAS_* ifdefs

2021-01-29 Thread Richard Henderson
The opcodes always exist, regardless of whether or not they are enabled. Remove the unnecessary ifdefs. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.c.inc | 82 1 file changed, 82 deletions(-) diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/t