Re: [PATCH v3 02/19] python/qmp: Fix type of SocketAddrT

2021-06-03 Thread Philippe Mathieu-Daudé
On 6/3/21 2:37 AM, John Snow wrote: > In porting the qom tools, qmp-shell, etc; it becomes evident that this > type is wrong. > > This is an integer, not a string. We didn't catch this before because > none of QEMUMonitorProtocol's *users* happen to be checked, and the > internal logic of this cla

[PATCH v3 02/19] python/qmp: Fix type of SocketAddrT

2021-06-02 Thread John Snow
In porting the qom tools, qmp-shell, etc; it becomes evident that this type is wrong. This is an integer, not a string. We didn't catch this before because none of QEMUMonitorProtocol's *users* happen to be checked, and the internal logic of this class is otherwise self-consistent. Additionally, m