Re: [PATCH v3 01/20] accel/tcg: restrict assert on icount_enabled to qemu-system

2024-08-12 Thread Deepak Gupta
On Wed, Aug 07, 2024 at 10:48:56AM +1000, Richard Henderson wrote: On 8/7/24 10:06, Deepak Gupta wrote: commit 16ad9788 [1] restricted icount to qemu-system only. Although assert in `cpu_loop_exec_tb` is on `icount_enabled()` which is 0 when its qemu-user and debug build starts asserting. Move a

Re: [PATCH v3 01/20] accel/tcg: restrict assert on icount_enabled to qemu-system

2024-08-07 Thread Deepak Gupta
On Wed, Aug 07, 2024 at 10:48:56AM +1000, Richard Henderson wrote: On 8/7/24 10:06, Deepak Gupta wrote: commit 16ad9788 [1] restricted icount to qemu-system only. Although assert in `cpu_loop_exec_tb` is on `icount_enabled()` which is 0 when its qemu-user and debug build starts asserting. Move a

Re: [PATCH v3 01/20] accel/tcg: restrict assert on icount_enabled to qemu-system

2024-08-06 Thread Richard Henderson
On 8/7/24 10:06, Deepak Gupta wrote: commit 16ad9788 [1] restricted icount to qemu-system only. Although assert in `cpu_loop_exec_tb` is on `icount_enabled()` which is 0 when its qemu-user and debug build starts asserting. Move assert for qemu-system. [1] - https://lists.gnu.org/archive/html/qem

[PATCH v3 01/20] accel/tcg: restrict assert on icount_enabled to qemu-system

2024-08-06 Thread Deepak Gupta
commit 16ad9788 [1] restricted icount to qemu-system only. Although assert in `cpu_loop_exec_tb` is on `icount_enabled()` which is 0 when its qemu-user and debug build starts asserting. Move assert for qemu-system. [1] - https://lists.gnu.org/archive/html/qemu-riscv/2024-01/msg00608.html Signed-o