Re: [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-10-30 Thread Aleksandar Markovic
> > In case you, for any reason, can't complete this by softfreeze, I advice >> you not to rush, and postpone the integration to 5.0. >> > > This series doesn't provide any useful feature, it is a simple cleanup, > posted and reviewed before soft freeze, so we still have 1 week (until > hard freeze

Re: [Xen-devel] [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-10-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191026180143.7369-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Xen-devel] [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge Type: series

Re: [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-10-30 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 10/27/19 8:44 AM, Aleksandar Markovic wrote: On Saturday, October 26, 2019, Philippe Mathieu-Daudé > wrote: Changes since v2 [0]: - Use a #define - Reword one description - Added review tags (thanks all for reviewing!) Changes sin

Re: [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-10-27 Thread Aleksandar Markovic
On Saturday, October 26, 2019, Philippe Mathieu-Daudé wrote: > Changes since v2 [0]: > - Use a #define > - Reword one description > - Added review tags (thanks all for reviewing!) > > Changes since v1 [1]: > - Removed patch reintroducing DO_UPCAST() use (thuth) > - Took various patches out to red

[PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-10-26 Thread Philippe Mathieu-Daudé
Changes since v2 [0]: - Use a #define - Reword one description - Added review tags (thanks all for reviewing!) Changes since v1 [1]: - Removed patch reintroducing DO_UPCAST() use (thuth) - Took various patches out to reduce series (thuth) - Added review tags (thanks all for reviewing!) $ git back